Browse code
format
Greg Wiley authored on 03/05/2017 00:40:02
Showing 6 changed files
Showing 6 changed files
... | ... |
@@ -66,7 +66,8 @@ int impl::authenticate (const pam_request &request) |
66 | 66 |
int auth_result = validator_.validate (requester, input.user_name, |
67 | 67 |
input.token) ? PAM_SUCCESS : PAM_AUTH_ERR; |
68 | 68 |
|
69 |
- logger_.log (auth_result, requester_user_name, input.user_name, input.token); |
|
69 |
+ logger_.log (auth_result, requester_user_name, input.user_name, |
|
70 |
+ input.token); |
|
70 | 71 |
return auth_result; |
71 | 72 |
} |
72 | 73 |
} |
... | ... |
@@ -48,12 +48,14 @@ void use_sessions (dual_control_configuration &config, sessions_ifc *value) |
48 | 48 |
config.sessions = sessions (sessions::delegate (value)); |
49 | 49 |
} |
50 | 50 |
|
51 |
-class fake_sessions : public sessions_ifc { |
|
52 |
- private: |
|
53 |
- std::string user_; |
|
54 |
- public: |
|
55 |
- fake_sessions(const std::string &user) : user_(user) {} |
|
56 |
- std::string user_name (const pam_request &request) const { |
|
51 |
+class fake_sessions : public sessions_ifc |
|
52 |
+{ |
|
53 |
+private: |
|
54 |
+ std::string user_; |
|
55 |
+public: |
|
56 |
+ fake_sessions (const std::string &user) : user_ (user) {} |
|
57 |
+ std::string user_name (const pam_request &request) const |
|
58 |
+ { |
|
57 | 59 |
return user_; |
58 | 60 |
} |
59 | 61 |
|
... | ... |
@@ -67,7 +69,8 @@ private: |
67 | 69 |
std::string authorizer_user_name_; |
68 | 70 |
std::string token_; |
69 | 71 |
public: |
70 |
- void log (int result, const std::string &requester_user_name, const std::string &authorizer_user_name, |
|
72 |
+ void log (int result, const std::string &requester_user_name, |
|
73 |
+ const std::string &authorizer_user_name, |
|
71 | 74 |
const std::string &token) |
72 | 75 |
{ |
73 | 76 |
result_ = result; |
... | ... |
@@ -115,11 +118,13 @@ private: |
115 | 118 |
std::string token_; |
116 | 119 |
public: |
117 | 120 |
fake_validator (const std::string &requester, const std::string &authorizer, |
118 |
- const std::string &token): requester_(requester), authorizer_(authorizer), token_ (token) {} |
|
121 |
+ const std::string &token): requester_ (requester), authorizer_ (authorizer), |
|
122 |
+ token_ (token) {} |
|
119 | 123 |
bool validate (const std::string &requester, const std::string &authorizer, |
120 | 124 |
const std::string &token) |
121 | 125 |
{ |
122 |
- return requester_ == requester && authorizer_ == authorizer && token_ == token; |
|
126 |
+ return requester_ == requester && authorizer_ == authorizer |
|
127 |
+ && token_ == token; |
|
123 | 128 |
} |
124 | 129 |
}; |
125 | 130 |
|
... | ... |
@@ -147,12 +152,13 @@ int authenticate_validates_with_received_token() |
147 | 152 |
{ |
148 | 153 |
// given |
149 | 154 |
dual_control_configuration configuration; |
150 |
- std::string requester("requester"); |
|
151 |
- std::string authorizer("authorizer"); |
|
152 |
- std::string token("token"); |
|
153 |
- use_validator (configuration, new fake_validator (requester, authorizer, token)); |
|
155 |
+ std::string requester ("requester"); |
|
156 |
+ std::string authorizer ("authorizer"); |
|
157 |
+ std::string token ("token"); |
|
158 |
+ use_validator (configuration, new fake_validator (requester, authorizer, |
|
159 |
+ token)); |
|
154 | 160 |
use_conversation (configuration, new fake_conversation (authorizer, token)); |
155 |
- use_sessions(configuration, new fake_sessions(requester)); |
|
161 |
+ use_sessions (configuration, new fake_sessions (requester)); |
|
156 | 162 |
dual_control dc (dual_control::create (configuration)); |
157 | 163 |
pam_handle_t *handle (0); |
158 | 164 |
std::vector<std::string> arguments; |
... | ... |
@@ -170,7 +176,8 @@ int authenticate_fails_with_wrong_user() |
170 | 176 |
// given |
171 | 177 |
dual_control_configuration configuration; |
172 | 178 |
std::string token ("token"); |
173 |
- use_validator (configuration, new fake_validator ("requester", "user", token)); |
|
179 |
+ use_validator (configuration, new fake_validator ("requester", "user", |
|
180 |
+ token)); |
|
174 | 181 |
use_conversation (configuration, new fake_conversation ("wrong user", |
175 | 182 |
token)); |
176 | 183 |
dual_control dc (dual_control::create (configuration)); |
... | ... |
@@ -187,9 +194,10 @@ int authenticate_fails_with_wrong_token() |
187 | 194 |
{ |
188 | 195 |
// given |
189 | 196 |
dual_control_configuration configuration; |
190 |
- std::string requester("requester"); |
|
191 |
- std::string authorizer("authorizer"); |
|
192 |
- use_validator (configuration, new fake_validator (requester, authorizer, "token")); |
|
197 |
+ std::string requester ("requester"); |
|
198 |
+ std::string authorizer ("authorizer"); |
|
199 |
+ use_validator (configuration, new fake_validator (requester, authorizer, |
|
200 |
+ "token")); |
|
193 | 201 |
use_conversation (configuration, new fake_conversation (authorizer, |
194 | 202 |
"wrong token")); |
195 | 203 |
dual_control dc (dual_control::create (configuration)); |
... | ... |
@@ -206,12 +214,13 @@ int logs_authentication() |
206 | 214 |
{ |
207 | 215 |
//given |
208 | 216 |
dual_control_configuration configuration; |
209 |
- std::string requester("requester"); |
|
210 |
- std::string authorizer("authorizer"); |
|
217 |
+ std::string requester ("requester"); |
|
218 |
+ std::string authorizer ("authorizer"); |
|
211 | 219 |
std::string token ("token"); |
212 |
- use_validator (configuration, new fake_validator (requester, authorizer, token)); |
|
220 |
+ use_validator (configuration, new fake_validator (requester, authorizer, |
|
221 |
+ token)); |
|
213 | 222 |
use_conversation (configuration, new fake_conversation (authorizer, token)); |
214 |
- use_sessions(configuration, new fake_sessions(requester)); |
|
223 |
+ use_sessions (configuration, new fake_sessions (requester)); |
|
215 | 224 |
mock_logger *test_logger; |
216 | 225 |
use_logger (configuration, test_logger = new mock_logger); |
217 | 226 |
dual_control dc (dual_control::create (configuration)); |
... | ... |
@@ -235,13 +244,13 @@ int logs_authentication_failure() |
235 | 244 |
{ |
236 | 245 |
//given |
237 | 246 |
dual_control_configuration configuration; |
238 |
- std::string requester("requester"); |
|
239 |
- std::string authorizer("authorizer"); |
|
240 |
- std::string token("token"); |
|
247 |
+ std::string requester ("requester"); |
|
248 |
+ std::string authorizer ("authorizer"); |
|
249 |
+ std::string token ("token"); |
|
241 | 250 |
use_validator (configuration, new fake_validator (requester, authorizer, |
242 | 251 |
"not the received token")); |
243 | 252 |
use_conversation (configuration, new fake_conversation (authorizer, token)); |
244 |
- use_sessions(configuration, new fake_sessions(requester)); |
|
253 |
+ use_sessions (configuration, new fake_sessions (requester)); |
|
245 | 254 |
mock_logger *test_logger; |
246 | 255 |
use_logger (configuration, test_logger = new mock_logger); |
247 | 256 |
dual_control dc (dual_control::create (configuration)); |
... | ... |
@@ -23,7 +23,8 @@ private: |
23 | 23 |
sys_syslog syslog_; |
24 | 24 |
public: |
25 | 25 |
impl (const sys_syslog &sys_syslog) : syslog_ (sys_syslog) {} |
26 |
- void log (int result, const std::string &requester_user_name, const std::string &authorizer_user_name, |
|
26 |
+ void log (int result, const std::string &requester_user_name, |
|
27 |
+ const std::string &authorizer_user_name, |
|
27 | 28 |
const std::string &token) |
28 | 29 |
{ |
29 | 30 |
std::string message; |
... | ... |
@@ -34,19 +35,22 @@ public: |
34 | 35 |
case PAM_SUCCESS: |
35 | 36 |
facility = LOG_AUTHPRIV; |
36 | 37 |
priority = LOG_NOTICE; |
37 |
- message = requester_user_name + " " + authorizer_user_name + " " + token + " " + "success"; |
|
38 |
+ message = requester_user_name + " " + authorizer_user_name + " " + token + |
|
39 |
+ " " + "success"; |
|
38 | 40 |
break; |
39 | 41 |
|
40 | 42 |
case PAM_AUTH_ERR: |
41 | 43 |
facility = LOG_AUTHPRIV; |
42 | 44 |
priority = LOG_NOTICE; |
43 |
- message = requester_user_name + " " + authorizer_user_name + " " + token + " " + "fail"; |
|
45 |
+ message = requester_user_name + " " + authorizer_user_name + " " + token + |
|
46 |
+ " " + "fail"; |
|
44 | 47 |
break; |
45 | 48 |
|
46 | 49 |
default: |
47 | 50 |
facility = LOG_AUTH; |
48 | 51 |
priority = LOG_ERR; |
49 |
- message = requester_user_name + " " + authorizer_user_name + " pam returned error"; |
|
52 |
+ message = requester_user_name + " " + authorizer_user_name + |
|
53 |
+ " pam returned error"; |
|
50 | 54 |
break; |
51 | 55 |
} |
52 | 56 |
|
... | ... |
@@ -21,7 +21,8 @@ class logger_ifc |
21 | 21 |
{ |
22 | 22 |
public: |
23 | 23 |
virtual ~logger_ifc() {} |
24 |
- virtual void log (int result, const std::string &requester_user_name, const std::string &authorizer_user_name, |
|
24 |
+ virtual void log (int result, const std::string &requester_user_name, |
|
25 |
+ const std::string &authorizer_user_name, |
|
25 | 26 |
const std::string &token) {}; |
26 | 27 |
}; |
27 | 28 |
|
... | ... |
@@ -35,7 +36,8 @@ public: |
35 | 36 |
logger (const delegate &delegate) : delegate_ |
36 | 37 |
(delegate) {} |
37 | 38 |
logger() : logger (delegate (new logger_ifc)) {} |
38 |
- void log (int result, const std::string &requester_user_name, const std::string &authorizer_user_name, |
|
39 |
+ void log (int result, const std::string &requester_user_name, |
|
40 |
+ const std::string &authorizer_user_name, |
|
39 | 41 |
const std::string &token) |
40 | 42 |
{ |
41 | 43 |
delegate_->log (result, requester_user_name, authorizer_user_name, token); |
... | ... |
@@ -60,7 +60,8 @@ int logs_success() |
60 | 60 |
|
61 | 61 |
//then |
62 | 62 |
check (capture->facility == LOG_AUTHPRIV, "facility does not match"); |
63 |
- check (capture->message == requester_user + " " + authorizer_user + " " + token + " " + "success", |
|
63 |
+ check (capture->message == requester_user + " " + authorizer_user + " " + |
|
64 |
+ token + " " + "success", |
|
64 | 65 |
"message does not match"); |
65 | 66 |
check (capture->priority == LOG_NOTICE, "priority does not match"); |
66 | 67 |
check (capture->closed, "syslog not closed"); |
... | ... |
@@ -84,7 +85,8 @@ int logs_failure() |
84 | 85 |
|
85 | 86 |
//then |
86 | 87 |
check (capture->facility == LOG_AUTHPRIV, "facility does not match"); |
87 |
- check (capture->message == requester + " " + authorizer + " " + token + " " + "fail", |
|
88 |
+ check (capture->message == requester + " " + authorizer + " " + token + " " |
|
89 |
+ + "fail", |
|
88 | 90 |
"message does not match"); |
89 | 91 |
check (capture->priority == LOG_NOTICE, "priority does not match"); |
90 | 92 |
check (capture->closed, "syslog not closed"); |
... | ... |
@@ -108,7 +110,8 @@ int logs_pam_service_error() |
108 | 110 |
|
109 | 111 |
//then |
110 | 112 |
check (capture->facility == LOG_AUTH, "facility does not match"); |
111 |
- check (capture->message == requester + " " + authorizer + " pam returned error", |
|
113 |
+ check (capture->message == requester + " " + authorizer + |
|
114 |
+ " pam returned error", |
|
112 | 115 |
"message does not match"); |
113 | 116 |
check (capture->priority == LOG_ERR, "priority does not match"); |
114 | 117 |
check (capture->closed, "syslog not closed"); |