@@ -10,6 +10,7 @@

  */

 #include <syslog.h>

+#include <security/pam_modules.h>

 #include "sys_syslog.h"

 #include "logger.h"

@@ -22,7 +23,8 @@ namespace {

             impl(const sys_syslog &sys_syslog) : syslog_(sys_syslog) {}

             void log (int result, const std::string &user_name,

               const std::string &token) {

-                std::string message(user_name + " " + token + " success");

+                std::string pam_result = result == PAM_SUCCESS ? "success" : "fail";

+                std::string message(user_name + " " + token + " " + pam_result);

                 syslog_.openlog("dual-control", 0, LOG_AUTHPRIV);

                 syslog_.syslog(LOG_NOTICE, message.c_str());

@@ -64,12 +64,34 @@ int logs_success() {

     succeed();

 }

+int logs_failure() {

+    //given

+    mock_syslog *capture = new mock_syslog;

+    sys_syslog::delegate test_delegate(capture);

+    sys_syslog test_syslog(test_delegate);

+    logger logger = logger::create(test_syslog);

+    std::string user("user");

+    std::string token("token");

+

+    //when

+    logger.log(PAM_AUTH_ERR, user, token);

+

+    //then

+    check(capture->facility == LOG_AUTHPRIV, "facility does not match");

+    check(capture->message == user + " " + token + " " + "fail", "message does not match");

+    check(capture->priority == LOG_NOTICE, "priority does not match");

+    check(capture->closed, "syslog not closed");

+    check(capture->ident == "dual-control", "dual-control");

+    succeed();

+}

+

 RESET_VARS_START

 RESET_VARS_END

 int run_tests()

 {

     test (logs_success);

+    test (logs_failure);

     succeed();

 }