Browse code
formatting
jbalcita authored on 10/05/2017 18:04:45
Showing 4 changed files
Showing 4 changed files
... | ... |
@@ -98,7 +98,8 @@ public: |
98 | 98 |
{ |
99 | 99 |
return token_; |
100 | 100 |
} |
101 |
- std::string logged_reason() { |
|
101 |
+ std::string logged_reason() |
|
102 |
+ { |
|
102 | 103 |
return reason_; |
103 | 104 |
} |
104 | 105 |
}; |
... | ... |
@@ -112,7 +113,7 @@ private: |
112 | 113 |
public: |
113 | 114 |
fake_conversation (const std::string &user_name, |
114 | 115 |
const std::string &token, const std::string &reason) : |
115 |
- user_name_ (user_name), token_ (token), reason_(reason) {} |
|
116 |
+ user_name_ (user_name), token_ (token), reason_ (reason) {} |
|
116 | 117 |
conversation_result initiate (const pam_request &request) |
117 | 118 |
{ |
118 | 119 |
return {user_name_, token_, reason_}; |
... | ... |
@@ -128,8 +129,10 @@ private: |
128 | 129 |
std::string reason_; |
129 | 130 |
public: |
130 | 131 |
fake_validator (const std::string &requester, const std::string &authorizer, |
131 |
- const std::string &token, const std::string &reason): requester_ (requester), authorizer_ (authorizer), |
|
132 |
- token_ (token), reason_(reason) {} |
|
132 |
+ const std::string &token, |
|
133 |
+ const std::string &reason): requester_ (requester), |
|
134 |
+ authorizer_ (authorizer), |
|
135 |
+ token_ (token), reason_ (reason) {} |
|
133 | 136 |
bool validate (const std::string &requester, const std::string &authorizer, |
134 | 137 |
const std::string &token, const std::string &reason) override |
135 | 138 |
{ |
... | ... |
@@ -165,10 +168,11 @@ int authenticate_validates_with_received_token() |
165 | 168 |
std::string requester ("requester"); |
166 | 169 |
std::string authorizer ("authorizer"); |
167 | 170 |
std::string token ("token"); |
168 |
- std::string reason("reason"); |
|
171 |
+ std::string reason ("reason"); |
|
169 | 172 |
use_validator (configuration, new fake_validator (requester, authorizer, |
170 | 173 |
token, reason)); |
171 |
- use_conversation (configuration, new fake_conversation (authorizer, token, reason)); |
|
174 |
+ use_conversation (configuration, new fake_conversation (authorizer, token, |
|
175 |
+ reason)); |
|
172 | 176 |
use_sessions (configuration, new fake_sessions (requester)); |
173 | 177 |
dual_control dc (dual_control::create (configuration)); |
174 | 178 |
pam_handle_t *handle (0); |
... | ... |
@@ -187,7 +191,7 @@ int authenticate_fails_with_wrong_user() |
187 | 191 |
// given |
188 | 192 |
dual_control_configuration configuration; |
189 | 193 |
std::string token ("token"); |
190 |
- std::string reason("reason"); |
|
194 |
+ std::string reason ("reason"); |
|
191 | 195 |
use_validator (configuration, new fake_validator ("requester", "user", |
192 | 196 |
token, reason)); |
193 | 197 |
use_conversation (configuration, new fake_conversation ("wrong user", |
... | ... |
@@ -229,10 +233,11 @@ int logs_authentication() |
229 | 233 |
std::string requester ("requester"); |
230 | 234 |
std::string authorizer ("authorizer"); |
231 | 235 |
std::string token ("token"); |
232 |
- std::string reason("reason"); |
|
236 |
+ std::string reason ("reason"); |
|
233 | 237 |
use_validator (configuration, new fake_validator (requester, authorizer, |
234 | 238 |
token, reason)); |
235 |
- use_conversation (configuration, new fake_conversation (authorizer, token, reason)); |
|
239 |
+ use_conversation (configuration, new fake_conversation (authorizer, token, |
|
240 |
+ reason)); |
|
236 | 241 |
use_sessions (configuration, new fake_sessions (requester)); |
237 | 242 |
mock_logger *test_logger; |
238 | 243 |
use_logger (configuration, test_logger = new mock_logger); |
... | ... |
@@ -252,7 +257,7 @@ int logs_authentication() |
252 | 257 |
"logged token should be token"); |
253 | 258 |
std::cout <<test_logger->logged_reason() << std::endl; |
254 | 259 |
check (test_logger->logged_reason() == reason, |
255 |
- "logged reason should be reason"); |
|
260 |
+ "logged reason should be reason"); |
|
256 | 261 |
succeed(); |
257 | 262 |
} |
258 | 263 |
|
... | ... |
@@ -266,7 +271,8 @@ int logs_authentication_failure() |
266 | 271 |
std::string reason ("reason"); |
267 | 272 |
use_validator (configuration, new fake_validator (requester, authorizer, |
268 | 273 |
"not the received token", reason)); |
269 |
- use_conversation (configuration, new fake_conversation (authorizer, token, reason)); |
|
274 |
+ use_conversation (configuration, new fake_conversation (authorizer, token, |
|
275 |
+ reason)); |
|
270 | 276 |
use_sessions (configuration, new fake_sessions (requester)); |
271 | 277 |
mock_logger *test_logger; |
272 | 278 |
use_logger (configuration, test_logger = new mock_logger); |
... | ... |
@@ -42,7 +42,8 @@ public: |
42 | 42 |
const std::string &token, |
43 | 43 |
const std::string &reason) |
44 | 44 |
{ |
45 |
- delegate_->log (result, requester_user_name, authorizer_user_name, token, reason); |
|
45 |
+ delegate_->log (result, requester_user_name, authorizer_user_name, token, |
|
46 |
+ reason); |
|
46 | 47 |
} |
47 | 48 |
static logger create (const sys_syslog &sys_syslog); |
48 | 49 |
}; |
... | ... |
@@ -54,14 +54,15 @@ int logs_success() |
54 | 54 |
std::string requester_user ("requester_user"); |
55 | 55 |
std::string authorizer_user ("authorizer_user"); |
56 | 56 |
std::string token ("token"); |
57 |
- std::string reason("reason"); |
|
57 |
+ std::string reason ("reason"); |
|
58 | 58 |
|
59 | 59 |
//when |
60 | 60 |
logger.log (PAM_SUCCESS, requester_user, authorizer_user, token, reason); |
61 | 61 |
|
62 | 62 |
//then |
63 | 63 |
check (capture->facility == LOG_AUTHPRIV, "facility does not match"); |
64 |
- check (capture->message == requester_user + " " + authorizer_user + " " + reason + " " + |
|
64 |
+ check (capture->message == requester_user + " " + authorizer_user + " " + |
|
65 |
+ reason + " " + |
|
65 | 66 |
"success", |
66 | 67 |
"message does not match"); |
67 | 68 |
check (capture->priority == LOG_NOTICE, "priority does not match"); |
... | ... |
@@ -80,7 +81,7 @@ int logs_failure() |
80 | 81 |
std::string requester ("requestuser"); |
81 | 82 |
std::string authorizer ("authuser"); |
82 | 83 |
std::string token ("token"); |
83 |
- std::string reason("reason"); |
|
84 |
+ std::string reason ("reason"); |
|
84 | 85 |
|
85 | 86 |
//when |
86 | 87 |
logger.log (PAM_AUTH_ERR, requester, authorizer, token, reason); |
... | ... |
@@ -106,7 +107,7 @@ int logs_pam_service_error() |
106 | 107 |
std::string requester ("user"); |
107 | 108 |
std::string authorizer ("user"); |
108 | 109 |
std::string token ("token"); |
109 |
- std::string reason("reason"); |
|
110 |
+ std::string reason ("reason"); |
|
110 | 111 |
|
111 | 112 |
//when |
112 | 113 |
logger.log (PAM_SERVICE_ERR, requester, authorizer, token, reason); |
... | ... |
@@ -106,7 +106,8 @@ bool validator_fails_incorrect_token() |
106 | 106 |
validator validator = validator::create (directory, tokens); |
107 | 107 |
|
108 | 108 |
// when |
109 |
- bool actual = validator.validate ("requester", user_name, "token", "reason"); |
|
109 |
+ bool actual = validator.validate ("requester", user_name, "token", |
|
110 |
+ "reason"); |
|
110 | 111 |
|
111 | 112 |
// then |
112 | 113 |
check (!actual, "should not be valid"); |
... | ... |
@@ -154,7 +155,8 @@ bool validator_fails_with_unknown_requester() |
154 | 155 |
succeed(); |
155 | 156 |
} |
156 | 157 |
|
157 |
-bool validator_fails_on_empty_reason() { |
|
158 |
+bool validator_fails_on_empty_reason() |
|
159 |
+{ |
|
158 | 160 |
//given |
159 | 161 |
std::string requester_user_name (""); |
160 | 162 |
std::string authorizer_user_name ("authorizer"); |
... | ... |
@@ -170,7 +172,7 @@ bool validator_fails_on_empty_reason() { |
170 | 172 |
authorizer_token, reason); |
171 | 173 |
|
172 | 174 |
//then |
173 |
- check(!actual, "should not be valid"); |
|
175 |
+ check (!actual, "should not be valid"); |
|
174 | 176 |
succeed(); |
175 | 177 |
} |
176 | 178 |
|