@@ -37,9 +37,9 @@ public:

         const std::string file_path (user.home_directory() + "/.dual_control");

         fstreams::pstream stream (fstreams_.open_fstream (file_path));

-        // TODO: decode key

-        std::vector<char> line_v(40);

-        stream->getline(line_v.data(), line_v.size());

+        // TODO: ignore newlines

+        std::vector<char> line_v(64);

+        stream->read(line_v.data(), line_v.size());

         if (stream->fail()) {

             return "";

@@ -103,7 +103,7 @@ int reads_from_the_right_file ()

     std::string home_directory = "/somedir";

     // hardcoded file name is .dual_control in the user's home directory

     std::string token_file = home_directory + "/.dual_control";

-    std::string token ("AAAAAAAA");

+    std::string token ("AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA");

     fstreams test_streams (fstreams::delegate (new fake_fstreams (token_file, token)));

     totp_generator generator (totp_generator::delegate (new fake_totp_generator (token)));

@@ -141,6 +141,30 @@ int returns_empty_string_if_file_open_fail()

     succeed();

 }

+int returns_empty_string_if_file_too_short()

+{

+    //given

+    std::string home_directory = "/somedir";

+    // hardcoded file name is .dual_control in the user's home directory

+    std::string token_file = home_directory + "/.dual_control";

+    // we want a 40-byte key, so we need a 64-byte base32-encoded file.

+    std::string token ("AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA");

+

+    fstreams test_streams (fstreams::delegate (new fake_fstreams (token_file, token)));

+    totp_generator generator (totp_generator::delegate (new fake_totp_generator (token)));

+

+    //file_reader test_file_reader (file_reader::delegate (new fake_file_reader));

+    user test_user (user::delegate (new fake_user (home_directory)));

+    tokens supplier (tokens::create (test_streams, generator));

+

+    //when

+    std::string actual = supplier.token (test_user);

+

+    //then

+    check (actual == "", "should have returned empty string");

+    succeed();

+}

+

 int writes_the_token ()

 {

     // given

@@ -169,6 +193,7 @@ int run_tests()

 {

     test (reads_from_the_right_file);

     test (returns_empty_string_if_file_open_fail);

+    test (returns_empty_string_if_file_too_short);

     test (writes_the_token);

     succeed();

 }