Browse code
fix some tests
Greg Wiley authored on 06/04/2017 16:26:05
Showing 2 changed files
Showing 2 changed files
... | ... |
@@ -32,7 +32,6 @@ void log_success() { |
32 | 32 |
|
33 | 33 |
int pam_sm_setcred_returns_success() { |
34 | 34 |
//given |
35 |
- reset_vars(); |
|
36 | 35 |
|
37 | 36 |
//when |
38 | 37 |
int result = pam_sm_setcred(NULL, 0, 0, NULL); |
... | ... |
@@ -43,7 +42,7 @@ int pam_sm_setcred_returns_success() { |
43 | 42 |
|
44 | 43 |
int pam_sm_authenticate_success_invokes_log_success() { |
45 | 44 |
// given |
46 |
- reset_vars(); |
|
45 |
+ validation_to_return = 1; |
|
47 | 46 |
log_success_invoked = 0; |
48 | 47 |
|
49 | 48 |
//when |
... | ... |
@@ -53,7 +52,6 @@ int pam_sm_authenticate_success_invokes_log_success() { |
53 | 52 |
|
54 | 53 |
int succeeds_with_valid_token() { |
55 | 54 |
//given |
56 |
- reset_vars(); |
|
57 | 55 |
|
58 | 56 |
//when |
59 | 57 |
int result = pam_sm_authenticate(NULL, 0, 0, NULL); |
... | ... |
@@ -64,7 +62,6 @@ int succeeds_with_valid_token() { |
64 | 62 |
|
65 | 63 |
int fails_with_invalid_token() { |
66 | 64 |
//given |
67 |
- reset_vars(); |
|
68 | 65 |
validation_to_return = 0; |
69 | 66 |
|
70 | 67 |
//when |
... | ... |
@@ -83,12 +80,6 @@ int runtests() { |
83 | 80 |
} |
84 | 81 |
|
85 | 82 |
int main(int argc, char* argv[]) { |
86 |
-// check(pam_sm_setcred_returns_success(), "set cred failed\n"); |
|
87 |
-// check(pam_sm_authenticate_success_invokes_log_success(), "authenticate invokes log_success failed\n"); |
|
88 |
-// check(succeeds_with_valid_token(), "succeeds with valid token failed\n"); |
|
89 |
-// check(fails_with_invalid_token(), "fails with invalid token failed\n") |
|
90 |
- |
|
91 | 83 |
return !runtests(); |
92 |
- |
|
93 | 84 |
} |
94 | 85 |
|
... | ... |
@@ -13,9 +13,15 @@ |
13 | 13 |
#define checkstr(expected, actual, name) \ |
14 | 14 |
check(!strcmp(actual, expected), name " should be '" expected "'") |
15 | 15 |
|
16 |
+#ifdef reset_vars |
|
17 |
+#define _reset reset_vars() |
|
18 |
+#else |
|
19 |
+#define _reset |
|
20 |
+#endif |
|
21 |
+ |
|
16 | 22 |
#define test(NAME) \ |
17 | 23 |
{ \ |
18 |
- fprintf(stderr, "here %s\n", #NAME); \ |
|
24 |
+ _reset \ |
|
19 | 25 |
int result = NAME (); \ |
20 | 26 |
if (!result) { \ |
21 | 27 |
fprintf(stderr, "test failed: %s\n", #NAME); \ |