@@ -23,11 +23,29 @@ namespace {

             impl(const sys_syslog &sys_syslog) : syslog_(sys_syslog) {}

             void log (int result, const std::string &user_name,

               const std::string &token) {

-                std::string pam_result = result == PAM_SUCCESS ? "success" : "fail";

-                std::string message(user_name + " " + token + " " + pam_result);

+                std::string message;

+                int facility;

+                int priority;

+                switch (result) {

+                   case PAM_SUCCESS:

+                       facility = LOG_AUTHPRIV;

+                       priority = LOG_NOTICE;

+                       message = user_name + " " + token + " " + "success";

+                       break;

+                   case PAM_AUTH_ERR:

+                       facility = LOG_AUTHPRIV;

+                       priority = LOG_NOTICE;

+                       message = user_name + " " + token + " " + "fail";

+                       break;

+                    default:

+                        facility = LOG_AUTH;

+                        priority = LOG_ERR;

+                        message = "pam returned error";

+                        break;

+                }

-                syslog_.openlog("dual-control", 0, LOG_AUTHPRIV);

-                syslog_.syslog(LOG_NOTICE, message.c_str());

+                syslog_.openlog("dual-control", 0, facility);

+                syslog_.syslog(priority, message.c_str());

                syslog_.closelog();

             }

     };

@@ -85,6 +85,27 @@ int logs_failure() {

     succeed();

 }

+int logs_pam_service_error() {

+    //given

+    mock_syslog *capture = new mock_syslog;

+    sys_syslog::delegate test_delegate(capture);

+    sys_syslog test_syslog(test_delegate);

+    logger logger = logger::create(test_syslog);

+    std::string user("user");

+    std::string token("token");

+

+    //when

+    logger.log(PAM_SERVICE_ERR, user, token);

+

+    //then

+    check(capture->facility == LOG_AUTH, "facility does not match");

+    check(capture->message == "pam returned error", "message does not match");

+    check(capture->priority == LOG_ERR, "priority does not match");

+    check(capture->closed, "syslog not closed");

+    check(capture->ident == "dual-control", "dual-control");

+    succeed();

+}

+

 RESET_VARS_START

 RESET_VARS_END

@@ -92,6 +113,7 @@ int run_tests()

 {

     test (logs_success);

     test (logs_failure);

+    test (logs_pam_service_error);

     succeed();

 }